Re: [Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

[Blue Swirl]

On Sat, Aug 11, 2012 at 5:44 PM, Peter Maydell <address@hidden> wrote:
> On 11 August 2012 16:11, Blue Swirl <address@hidden> wrote:
>> Configuring with Clang compiler with -Werror would not work after
>> improved checks:
>> /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates
>> to true [-Werror,-Wtautological-compare]
>> int main(void) { return preadv == preadv; }
>> /tmp/qemu-conf--25992-.c:13:26: error: self-comparison always
>> evaluates to true [-Werror,-Wtautological-compare]
>>     return epoll_create1 == epoll_create1;
>> /tmp/qemu-conf--25992-.c:3:13: error: explicitly assigning a variable
>> of type 'char **' to itself [-Werror,-Wself-assign]
>>     environ = environ;
>>
>> Avoid the errors by adjusting the tests.
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>
> Reviewed-by: Peter Maydell <address@hidden>

Thanks for the review, applied.

>
> -- PMM