Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

[Juan Quintela]

Peter Maydell <address@hidden> wrote:
> Add support for saving/loading bitmap.h bitmaps in vmstate.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This will be needed for saving/restoring the bitmap in sd.c which
> is introduced by Igor's latest patchset; the relevant VMSTATE line is:
>         VMSTATE_BITMAP(wp_groups, SDState, 1, wpgrps_size),
> (and you'll need to make wpgrps_size an int32_t, not uint32_t).
>
> Igor: I've only tested this fairly lightly, you'll probably want to
> do things like testing save on 32 bit and load on 64 bit and
> vice-versa.
>
>  savevm.c  |   41 +++++++++++++++++++++++++++++++++++++++++
>  vmstate.h |   13 +++++++++++++
>  2 files changed, 54 insertions(+)

Reviewed-by: Juan Quintela <address@hidden>

I haven't tested it, but Igor did, so O;-)

I can add it to my next pull request, or let it on Igor one that is the
one using it.  Both ways work for me.