[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection |
Date: |
Mon, 13 Aug 2012 14:06:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-08-13 10:35, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <address@hidden>
>
> This is required to get past the following assert with:
>
> commit 1523ed9e1d46b0b54540049d491475ccac7e6421
> Author: Jan Kiszka <address@hidden>
> Date: Thu May 17 10:32:39 2012 -0300
>
> virtio/vhost: Add support for KVM in-kernel MSI injection
>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Jan Kiszka <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Signed-off-by: Nicholas Bellinger <address@hidden>
> ---
> hw/msix.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 800fc32..c1e6dc3 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -544,6 +544,9 @@ void msix_unset_vector_notifiers(PCIDevice *dev)
> {
> int vector;
>
> + if (!dev->msix_vector_use_notifier && !dev->msix_vector_release_notifier)
> + return;
> +
> assert(dev->msix_vector_use_notifier &&
> dev->msix_vector_release_notifier);
>
>
I think to remember pointing out that there is a bug somewhere in the
reset code which deactivates a non-active vhost instance, no?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection, Blue Swirl, 2012/08/13
[Qemu-devel] [RFC-v2 2/6] vhost: Pass device path to vhost_dev_init(), Nicholas A. Bellinger, 2012/08/13
[Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi, Nicholas A. Bellinger, 2012/08/13