[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/35]: add new error format
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/35]: add new error format |
Date: |
Mon, 13 Aug 2012 10:32:03 -0300 |
On Sat, 11 Aug 2012 09:05:33 +0200
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> [...]
> > This series implements the 'Plan for error handling in QMP' as described
> > by Anthony in this email:
> >
> > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html
> >
> > Basically, this replaces almost all error classes by GenericError (the
> > exception are a few error classes used by libvirt) and drops the error
> > data memeber. This also adds a free form string to error_set().
> >
> > On the wire, we go from:
> >
> > { "error": { "class": "DeviceNotRemovable",
> > "data": { "device": "virtio0" },
> > "desc": "Device 'virtio0' is not removable" } }
> >
> > to:
> >
> > { "error": { "class": "GenericError",
> > "desc": "Device 'virtio0' is not removable" } }
> >
> > Internally, we go from:
> >
> > void error_set(Error **err, const char *fmt, ...);
> >
> > to:
> >
> > void error_set(Error **err, ErrorClass err_class, const char *fmt, ...);
>
> Glad to see this change in good shape in time for the release. Thanks,
> Luiz!
Thank you for your review!
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
- [Qemu-devel] [PATCH 19/35] qapi: qapi-types.h: don't include qapi/qapi-types-core.h, (continued)
- [Qemu-devel] [PATCH 19/35] qapi: qapi-types.h: don't include qapi/qapi-types-core.h, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 25/35] qerror: add proper ErrorClass value for QERR_ macros, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 27/35] hmp: hmp_change(): use error_get_class(), Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 22/35] qapi-schema: add ErrorClass enum, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 21/35] qapi: don't convert enum strings to lowercase, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 18/35] hmp: hmp.h: include qdict.h, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 33/35] qerror: drop qerror_table and qerror_format(), Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 32/35] error, qerror: pass desc string to error calls, Luiz Capitulino, 2012/08/10
- [Qemu-devel] [PATCH 17/35] block: block_int: include qerror.h, Luiz Capitulino, 2012/08/10
- Re: [Qemu-devel] [PATCH v3 00/35]: add new error format, Markus Armbruster, 2012/08/11
- Re: [Qemu-devel] [PATCH v3 00/35]: add new error format,
Luiz Capitulino <=