Re: [Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate

[Eric Blake]

On 08/13/2012 04:50 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  arch_init.c      | 2 ++
>  hmp.c            | 4 ++++
>  migration.c      | 2 ++
>  migration.h      | 1 +
>  qapi-schema.json | 4 ++++
>  5 files changed, 13 insertions(+)
> 

> +++ b/qapi-schema.json
> @@ -322,6 +322,9 @@
>  # @downtime: total downtime in milliseconds for the guest.
>  #        (since 1.2)
>  #
> +# @expected-downtime: expected downtime in milliseconds for the
> +#        guest in last walk of the dirty bitmap. (sincte 1.2)

s/sincte/since/

Should this field be marked optional?  That is, it makes sense to expose
the field while migration is ongoing, but when reporting the stats after
migration is complete, there is no longer any expected downtime.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature