Re: [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fix

[Michael Tokarev]

On 13.08.2012 22:18, Jan Kiszka wrote:
> 0cdd3d1444 fixed reading back the counter load time from the kernel
> while assuming the kernel would always update its load time on writing
> the state. That is only true for channel 1, and so pit_get_channel_info
> returned wrong output pin states for high counter values.
> 
> Fix this by applying the offset also on kvm_pit_put. For this purpose,
> we cache the clock offset in KVMPITState, only updating it on VM state
> changes or when we write the state while the VM is stopped.

Wug.  The fix (consisting of two halves) appears to be quite messy.
Is it a (temporary) workaround or a real solution?

And yes, this second half fixes the reported issue with grub timekeeping,
and should fix the seabios problem as well (so it shouldn't be necessary
to mess with timekeeping in seabios anymore).

Thank you Jan!

/mjt