Re: [Qemu-devel] [PATCH 1/2] vl: Round argument of -m up to multiple of 8KiB

[Markus Armbruster]

Avi Kivity <address@hidden> writes:

> On 08/14/2012 02:58 PM, Markus Armbruster wrote:
>> Partial pages make little sense and don't work.  Ensure the RAM size
>> is a multiple of any possible target's page size.
>> 
>> index d01256a..b411d45 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2708,11 +2708,13 @@ int main(int argc, char **argv, char **envp)
>>                      fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
>>                      exit(1);
>>                  }
>> -
>>                  if (value != (uint64_t)(ram_addr_t)value) {
>>                      fprintf(stderr, "qemu: ram size too large\n");
>>                      exit(1);
>>                  }
>> +                if (value & 0x1fff) {
>> +                    value = (value + 0x1fff) & ~0x1fff;
>> +                }
>
> value = QEMU_ALIGN_UP(value, 8192);

I looked for such a macro, but my greps missed.  Thanks!