[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength().
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength(). |
Date: |
Tue, 14 Aug 2012 10:08:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/14/2012 08:14 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block/quorum.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index f228428..a3f16ed 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -162,12 +162,21 @@ static void quorum_close(BlockDriverState *bs)
> g_free(s->bs);
> }
>
> +static int64_t quorum_getlength(BlockDriverState *bs)
> +{
> + BDRVQuorumState *s = bs->opaque;
> +
> + return bdrv_getlength(s->bs[0]);
Is this implementation right? Shouldn't this be a quorum decision,
where all s->bs[...] elements have to agree on the same size, or even
where they can differ on size, as long as all files with larger size
have unallocated holes past the size of the smaller member?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency, Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 1/9] quorum: Create quorum .c, add QuorumSingleAIOCB and QuorumAIOCB., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 5/9] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 6/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength()., Benoît Canet, 2012/08/14
- Re: [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength().,
Eric Blake <=
- [Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush()., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism., Benoît Canet, 2012/08/14
- [Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv., Benoît Canet, 2012/08/14
- Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency, Blue Swirl, 2012/08/14
- Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency, Stefan Hajnoczi, 2012/08/15
- Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency, Benoît Canet, 2012/08/20