[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open(). |
Date: |
Tue, 14 Aug 2012 18:56:52 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit :
> Am 10.08.2012 19:48, schrieb Benoît Canet:
> > Le Tuesday 07 Aug 2012 à 20:30:09 (+0000), Blue Swirl a écrit :
> >> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet <address@hidden> wrote:
> >>> Signed-off-by: Benoit Canet <address@hidden>
> >>> ---
> >>> block/quorum.c | 62
> >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>> 1 file changed, 62 insertions(+)
> >>>
> >>> diff --git a/block/quorum.c b/block/quorum.c
> >>> index e0405b6..de58ab8 100644
> >>> --- a/block/quorum.c
> >>> +++ b/block/quorum.c
> >>> @@ -47,11 +47,73 @@ struct QuorumAIOCB {
> >>> int vote_ret;
> >>> };
> >>>
> >>> +/* Valid quorum filenames look like
> >>> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image
> >>
> >> This syntax would mean that stacking for example curl or other network
> >> paths would not be possible. How about comma as separator?
> >
> > I just tried comma but it fail because the qemu command line parsing
> > catch it believing that the string next to the coma is another "file="
> > like options.
> >
> > Is there any other separator we can use ?
>
> I would ignore that for now, or you can introduce your own escaping of
> colons. The real solution is, once again, -blockdev.
Is -blockdev related to BlockBackend ?
Benoît
>
> Kevin
>
Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open()., Stefan Hajnoczi, 2012/08/08
[Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close()., Benoît Canet, 2012/08/07
[Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength()., Benoît Canet, 2012/08/07
[Qemu-devel] [RFC V2 08/10] quorum: Add quorum_co_flush()., Benoît Canet, 2012/08/07