[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_tab
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop |
Date: |
Tue, 14 Aug 2012 18:27:47 +0000 |
On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell <address@hidden> wrote:
> The code to initialise the target_to_host_errno_table[] array was
> accidentally inside the loop through checking and initialising all
> the supported ioctls. This was harmless but meant that we reinitialised the
> array several hundred times on startup.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> linux-user/syscall.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 3ba3ef5..1af68d2 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -4606,6 +4606,11 @@ void syscall_init(void)
> #undef STRUCT
> #undef STRUCT_SPECIAL
>
> + /* Build target_to_host_errno_table[] table from
> + * host_to_target_errno_table[]. */
> + for (i=0; i < ERRNO_TABLE_SIZE; i++)
Please add spaces around '=' and braces.
> + target_to_host_errno_table[host_to_target_errno_table[i]] = i;
> +
> /* we patch the ioctl size if necessary. We rely on the fact that
> no ioctl has all the bits at '1' in the size field */
> ie = ioctl_entries;
> @@ -4625,11 +4630,6 @@ void syscall_init(void)
> (size << TARGET_IOC_SIZESHIFT);
> }
>
> - /* Build target_to_host_errno_table[] table from
> - * host_to_target_errno_table[]. */
> - for (i=0; i < ERRNO_TABLE_SIZE; i++)
> - target_to_host_errno_table[host_to_target_errno_table[i]] =
> i;
> -
> /* automatic consistency check if same arch */
> #if (defined(__i386__) && defined(TARGET_I386) && defined(TARGET_ABI32)) || \
> (defined(__x86_64__) && defined(TARGET_X86_64))
> --
> 1.7.9.5
>
- [Qemu-devel] [PULL for-1.2 00/10] linux-user queue, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 01/10] linux-user: Fix incorrect TARGET_BLKBSZGET, TARGET_BLKBSZSET, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 10/10] linux-user: ARM: Ignore immediate value for svc in thumb mode, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 06/10] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 09/10] linux-user: Use init_guest_space when -R and -B are specified, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 08/10] linux-user: Factor out guest space probing into a function, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 02/10] linux-user: Fix SNDCTL_DSP_MAP{IN, OUT}BUF ioctl definitions, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 07/10] flatload: fix bss clearing, Peter Maydell, 2012/08/14
- [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop, Peter Maydell, 2012/08/14
- Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop,
Blue Swirl <=
[Qemu-devel] [PATCH 05/10] linux-user: make do_setsockopt support SOL_RAW ICMP_FILTER socket option, Peter Maydell, 2012/08/14
[Qemu-devel] [PATCH 04/10] linux-user: pass sockaddr from host to target, Peter Maydell, 2012/08/14
Re: [Qemu-devel] [PULL for-1.2 00/10] linux-user queue, Blue Swirl, 2012/08/14