Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/10] pseries: Export find_phb() utility function for PCI code

[David Gibson]

On Tue, Aug 14, 2012 at 01:45:53PM +0200, Alexander Graf wrote:
> On 08/08/2012 04:10 AM, David Gibson wrote:
> >From: Alexey Kardashevskiy <address@hidden>
> >
> >The pseries PCI code makes use of an internal find_dev() function which
> >locates a PCIDevice * given a (platform specific) bus ID and device
> >address.  Internally this needs to first locate the host bridge on which
> >the device resides based on the bus ID.  This patch exposes that host
> >bridge lookup as a separate function, which we will need later in the MSI
> >and VFIO code.
> >
> >Signed-off-by: Alexey Kardashevskiy <address@hidden>
> >Signed-off-by: David Gibson <address@hidden>
> >---
> >  hw/spapr_pci.c |   32 ++++++++++++++++++++++----------
> >  1 file changed, 22 insertions(+), 10 deletions(-)
> >
> >diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
> >index fcc358e..842068f 100644
> >--- a/hw/spapr_pci.c
> >+++ b/hw/spapr_pci.c
> >@@ -29,27 +29,39 @@
> >  #include "hw/spapr_pci.h"
> >  #include "exec-memory.h"
> >  #include <libfdt.h>
> >+#include "trace.h"
> 
> trace.h?

Sorry, probably leaked in from an earlier version or related patch
which did actually add some trace point calls.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson