qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for


From: Ruben Kerkhof
Subject: Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release
Date: Wed, 15 Aug 2012 10:12:42 +0200

On Tue, Aug 14, 2012 at 4:42 PM, Stefan Hajnoczi
<address@hidden> wrote:
> On Tue, Aug 14, 2012 at 08:32:31AM -0500, Anthony Liguori wrote:
>> To be replaced with live block copy.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>>  migration.c |    9 +++++++++
>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/migration.c b/migration.c
>> index 653a3c1..babccf4 100644
>> --- a/migration.c
>> +++ b/migration.c
>> @@ -482,10 +482,19 @@ void qmp_migrate(const char *uri, bool has_blk, bool 
>> blk,
>>      MigrationParams params;
>>      const char *p;
>>      int ret;
>> +    static bool suppress_deprecation_message;
>>
>>      params.blk = blk;
>>      params.shared = inc;
>>
>> +    if (blk && !suppress_deprecation_message) {
>> +        qerror_report(ERROR_CLASS_GENERIC_ERROR,
>
> qerror_report_once() would be nice :).
>
>> +                      "Block migration is deprecated.  "
>> +                      "See http://wiki.qemu.org/Features/LiveBlockCopy "
>
> The page doesn't exist, I think it should be:
> http://wiki.qemu.org/Features/LiveBlockMigration

Can the new live block copy method still use tcp just like the current
block migration? The wiki page only mentions iscsi.
I make extensive use of block migration over tcp, which works fine and
is handled by libvirt. I'd rather not introduce iscsi in my
environment.

Kind regards,

Ruben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]