[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor st
From: |
Pandarathil, Vijaymohan R |
Subject: |
Re: [Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor string size |
Date: |
Wed, 15 Aug 2012 15:52:17 +0000 |
Since you are introducing #define CPUID_VENDOR_SZ, you may as well want to
introduce
#define CPUID_VENDOR_OFF_1 0
#define CPUID_VENDOR_OFF_2 4
#define CPUID_VENDOR_OFF_3 8
and use them.
Regards
Vijay
-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Igor Mammedov
Sent: Friday, August 10, 2012 4:23 AM
To: address@hidden
Cc: address@hidden; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; address@hidden
Subject: [Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor
string size
Signed-off-by: Igor Mammedov <address@hidden>
---
target-i386/cpu.c | 6 +++---
target-i386/cpu.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d3ce849..368360f 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -863,13 +863,13 @@ static char *x86_cpuid_get_vendor(Object *obj, Error
**errp)
char *value;
int i;
- value = (char *)g_malloc(12 + 1);
+ value = (char *)g_malloc(CPUID_VENDOR_SZ + 1);
for (i = 0; i < 4; i++) {
value[i ] = env->cpuid_vendor1 >> (8 * i);
value[i + 4] = env->cpuid_vendor2 >> (8 * i);
value[i + 8] = env->cpuid_vendor3 >> (8 * i);
}
- value[12] = '\0';
+ value[CPUID_VENDOR_SZ] = '\0';
return value;
}
@@ -880,7 +880,7 @@ static void x86_cpuid_set_vendor(Object *obj, const char
*value,
CPUX86State *env = &cpu->env;
int i;
- if (strlen(value) != 12) {
+ if (strlen(value) != CPUID_VENDOR_SZ) {
error_set(errp, QERR_PROPERTY_VALUE_BAD, "",
"vendor", value);
return;
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 979682a..5c75704 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -440,6 +440,8 @@
#define CPUID_SVM_PAUSEFILTER (1 << 10)
#define CPUID_SVM_PFTHRESHOLD (1 << 12)
+#define CPUID_VENDOR_SZ 12
+
#define CPUID_VENDOR_INTEL_1 0x756e6547 /* "Genu" */
#define CPUID_VENDOR_INTEL_2 0x49656e69 /* "ineI" */
#define CPUID_VENDOR_INTEL_3 0x6c65746e /* "ntel" */
--
1.7.11.2
- Re: [Qemu-devel] [RFC 00/20] target-i386: convert CPU features into properties, (continued)
- Re: [Qemu-devel] [RFC 00/20] target-i386: convert CPU features into properties, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 19/20] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 13/20] target-i386: use visit_type_hz to parse tsc_freq property value, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 14/20] target-i386: introduce vendor-override property, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 18/20] target-i386: use properties to set/unset user specified features on CPU, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor string size, Igor Mammedov, 2012/08/10
- Re: [Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor string size,
Pandarathil, Vijaymohan R <=