[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qemu-img: Add json output option to the inf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qemu-img: Add json output option to the info command. |
Date: |
Wed, 15 Aug 2012 10:23:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/15/2012 08:54 AM, Benoît Canet wrote:
> This additionnal --machine=json option make qemu-img info output on
> stdout a JSON formated representation of the image informations.
>
> --machine=json was choosen instead of --format=json because the
> info command already have a -f parameter.
Do we want a counterpart '--machine=text' or '--machine=human' to
explicitly specify current output format?
> @@ -1113,10 +1174,20 @@ static int img_info(int argc, char **argv)
> char backing_filename[1024];
> char backing_filename2[1024];
> BlockDriverInfo bdi;
> + ImageInfo *image_info;
>
> fmt = NULL;
> + machine = NULL;
> for(;;) {
> - c = getopt(argc, argv, "f:h");
> + int option_index = 0;
> + static struct option long_options[] = {
> + {"help", no_argument, 0, 'h'},
> + {"format", required_argument, 0, 'f'},
> + {"machine", required_argument, 0, 'm'},
> + {0, 0, 0, 0}
> + };
> + c = getopt_long(argc, argv, "f:h",
> + long_options, &option_index);
getopt_long is not in POSIX. Are you sure this will compile on all
target platforms?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo., (continued)