qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] memory: could we add extra input param for memory_regio


From: Avi Kivity
Subject: Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?
Date: Sun, 19 Aug 2012 13:12:45 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

On 08/17/2012 10:41 AM, liu ping fan wrote:

>> The same example, in setup_cmd646_bar(PCIIDEState *d, int bus_num),  I
>> think we can not decide which is the type for @bar.  If using
>> object_dynamic_cast(@bar, TYPE_OBJECT) to tell whether it is Object or
>> not, it will raise exception.
>>
> And something like omap_mpu_timer_init() in file hw/omap1.c , the
> opaque(omap_mpu_timer_s) is got from g_malloc0, which makes things
> even harder to handle.  And the DO_CAST can not work for such issue.

IMO omap_mpu_timer_s should be a DeviceState.  Peter?

-- 
error compiling committee.c: too many arguments to function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]