qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races be


From: Stefan Priebe - Profihost AG
Subject: Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort
Date: Mon, 20 Aug 2012 09:34:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0

Am 20.08.2012 09:22, schrieb Paolo Bonzini:
Il 19/08/2012 21:22, Stefan Priebe - Profihost AG ha scritto:

No problem, my fault---I'm just back and I haven't really started again
all my stuff, so the patch was not tested.

This should fix it, though.

Booting works fine now. But the VM starts to hang after trying to unmap
large regions. No segfault or so just not reacting anymore.

This is expected; unfortunately cancellation right now is a synchronous
operation in the block layer.  SCSI is the first big user of
cancellation, and it would indeed benefit from asynchronous cancellation.

Without these three patches, you risk corruption in case the following
happens:

     qemu                 target
   -----------------------------------
     send unmap -------->
     cancel unmap ------>
     send write -------->
        <---------------- complete write
                          <unmap just written sector>
        <---------------- complete unmap
        <---------------- cancellation done (unmap complete)

mhm OK that makes sense. But i cannot even login via SSH and i also see no cancellation message in kernel log.

So what is the right way to test these patches? With my version i can still work via SSH.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]