[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC |
Date: |
Mon, 20 Aug 2012 04:20:36 -0400 (EDT) |
> > Hi,
> >
> > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> > >>
> > >> Just delete this and use
> > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> > >
> > > So you are telling me to undo a change that Gerd asked for -
> > > could
> > > you
> > > please at least debate about the merits of both approaches? the
> > > point of
> > > having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to
> > > allow
> > > usage of #if without defined, which is shorter.
> >
> > Hmm? That wasn't that I meant, must have been a tyops.
> > I mean you should just do ...
> >
> > #ifndef QXL_IO_MONITORS_CONFIG_ASYNC <--- without
> > *_HAS_*
> > #define QXL_IO_MONITORS_CONFIG_ASYNC $value
> > #endif
> >
> > then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
> > #ifdefs) at all ...
>
> So you want me to give the io a value - at this point I'd rather just
> add spice-protocol as a submodule, then we don't need to do any of
> this. How about it?
I'm retracting the suggestion, I'll define the missing bits as requested and
remove the ifdefs to satisfy Blue Swirl.
>
> >
> > cheers,
> > Gerd
> >
> >
> >
>
>
- [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions, (continued)
- [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v5 1.2 queue 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v6 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC,
Alon Levy <=
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
[Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions, Alon Levy, 2012/08/17