[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulat
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO |
Date: |
Mon, 20 Aug 2012 13:50:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 13/08/2012 21:43, Stefan Weil ha scritto:
>>
>> Label out_free_buf is only used with CONFIG_LINUX_AIO.
>>
>> off_t is always 32 bit with MinGW header files, but we
>> want support for large files, so off64_t is a better choice
>> here. It also avoids a compiler warning when the value
>> is right shifted by 32 bits.
Thanks, I squashed these in.
>> I noticed some messages from checkpatch.pl.
>> Some (but not all) of them were caused by the renamed file.
>> Maybe this file should be fixed before it is renamed.
If you make "git diff" detect renames they should go away.
> More changes are needed for user mode emulation.
> I hope they don't break linking of other executables:
There's need for more cleanup here, indeed. qemu-ga is including a lot
of unnecessary cruft via tools-obj-y (where it only needs tracing and
oslib, basically). cutils.c/iov.c are unnecessarily intertwined and
user mode emulation has no business including either. It should also
not need event_notifier.c.
Paolo
- [Qemu-devel] [PATCH v2 05/12] aio: add Win32 implementation, (continued)
- [Qemu-devel] [PATCH v2 05/12] aio: add Win32 implementation, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 06/12] linux-aio: use event notifiers, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 07/12] qemu-thread: add QemuSemaphore, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 08/12] aio: add generic thread-pool facility, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 09/12] block: switch posix-aio-compat to threadpool, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 10/12] raw: merge posix-aio-compat.c into block/raw-posix.c, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 11/12] raw-posix: rename raw-posix-aio.h, hide unavailable prototypes, Paolo Bonzini, 2012/08/07
- [Qemu-devel] [PATCH v2 12/12] raw-win32: add emulated AIO support, Paolo Bonzini, 2012/08/07
- Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO, Stefan Weil, 2012/08/11