[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-respons
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info |
|
Date: |
Tue, 21 Aug 2012 06:29:28 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/21/2012 06:17 AM, Eric Blake wrote:
> On 08/21/2012 06:03 AM, Michal Privoznik wrote:
>> This is a useful hint for users (or libvirt) whether a command returns
>> anything success and hence wait for reply or not.
>> +++ b/qapi-schema-guest.json
>> @@ -91,10 +91,14 @@
>> #
>> # @enabled: whether command is currently enabled by guest admin
>> #
>> +# @success-response: whether command report success response or not.
This sentence is also awkward. I suggest something like:
true unless the command does not respond on success
>> +# See 'uest-shutdown' command for more detailed info.
>
> s/uest/guest/
>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature