Re: [Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

[Gerd Hoffmann]

On 08/21/12 13:06, Gerd Hoffmann wrote:
> On 08/21/12 12:51, Alon Levy wrote:
>> Revision bumped to 4 for new IO support, enabled for spice-server >=
>> 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and
>> defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >=
>> 0.12.0.
> 
> All four patches added to spice patch queue.

Spoke too soon, it fails the build with old spice-server:

  CC    i386-softmmu/hw/i386/../qxl.o
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c: In
function ‘qxl_post_load’:
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c:2055:13:
warning: implicit declaration of function
‘spice_qxl_monitors_config_async’ [-Wimplicit-function-declaration]
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c:2055:13:
warning: nested extern declaration of ‘spice_qxl_monitors_config_async’
[-Wnested-externs]
  CC    i386-softmmu/hw/i386/../qxl-logger.o
[ ... ]
  LINK  i386-softmmu/qemu-system-i386
hw/i386/../qxl.o: In function `qxl_post_load':
qxl.c:(.text+0x3505): undefined reference to
`spice_qxl_monitors_config_async'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-i386] Error 1

cheers,
  Gerd