qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount w


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
Date: Wed, 22 Aug 2012 18:51:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0

Am 11.11.2011 20:45, schrieb Anthony Liguori:
> On 11/10/2011 05:38 AM, Max Filippov wrote:
>> With -icount, The vm_clock is updated with help from TCG (it counts
>> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
>> count is not available so KVM cannot provide this help.
>>
>> Signed-off-by: Max Filippov<address@hidden>
>> Acked-by: Paolo Bonzini<address@hidden>
> 
> Applied.  Thanks.

Applied to stable-0.15. Thanks,

Andreas

> Regards,
> 
> Anthony Liguori
> 
>> ---
>> v1 ->  v2 changes:
>> - cover both kvm and xen;
>> - add explanation text.
>> ---
>>   vl.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index f169aac..bb601e2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
>>           fprintf(stderr, "could not initialize alarm timer\n");
>>           exit(1);
>>       }
>> +
>> +    if (icount_option&&  (kvm_enabled() || xen_enabled())) {
>> +        fprintf(stderr, "-icount is not allowed with kvm or xen\n");
>> +        exit(1);
>> +    }
>>       configure_icount(icount_option);
>>
>>       if (net_init_clients()<  0) {

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]