[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command |
Date: |
Wed, 22 Aug 2012 23:42:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/22/2012 11:14 PM, Lei Li wrote:
> Signed-off-by: Lei Li <address@hidden>
Subject line uses '_', but the QMP command uses '-' [1]
> ---
> hmp-commands.hx | 16 ++++++++++++++++
> hmp.c | 15 +++++++++++++++
> hmp.h | 1 +
> qapi-schema.json | 28 ++++++++++++++++++++++++++++
> qemu-char.c | 36 ++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 33 +++++++++++++++++++++++++++++++++
> 6 files changed, 129 insertions(+), 0 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index f6104b0..829aea1 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -797,6 +797,22 @@ Inject an NMI on the given CPU (x86 only).
> ETEXI
>
> {
> + .name = "memchar-write",
HMP commands should use '_', not '-'.
> +++ b/qapi-schema.json
> @@ -235,6 +235,34 @@
> ##
> { 'command': 'query-chardev', 'returns': ['ChardevInfo'] }
>
> +{ 'enum': 'DataFormat'
> + 'data': [ 'utf8', 'base64' ] }
Missing documentation for DataFormat (see for example how @ErrorClass is
documented).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC v2 ATCH 0/4] char: expose MemoryCharDriver to users and provide QMP interface, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 1/6] qemu-char: Convert MemCharDriver to circular buffer, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 4/6] QAPI: Introduce memchar_read QMP command, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 5/6] Fix enumeration typo error, Lei Li, 2012/08/23
- [Qemu-devel] [PATCH 6/6] Expose MemCharDriver via command line, Lei Li, 2012/08/23