qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer hand


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer handler
Date: Thu, 23 Aug 2012 13:39:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

Il 23/08/2012 13:23, Jan Kiszka ha scritto:
> No need for this indirection via qemu_notify_event. On Unix, we already
> catch SIGALRM via signalfd (or its emulation) and run the handler
> synchronously. Under Win32, handlers run in separate threads. So we just
> need to grab the global lock around the handler execution.
> 
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> 
> The Unix side looks safe to me, but I'm not yet 100% confident about
> Win32. This is part of an ongoing effort to create separate alarm
> timers over their own io-threads. A lengthy effort.

Can you expand on this?

The Win32 bits look fine, but it's a bit scary to make the Unix and
Win32 paths so different.  It works well until we have a BQL for timers,
but would this complicate shrinking the scope of the BQL?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]