Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

[Brad Smith]

On Fri, Aug 24, 2012 at 10:55:10AM +0100, Peter Maydell wrote:
> On 24 August 2012 10:47, Brad Smith <address@hidden> wrote:
> > OpenBSD's uname works as expected with the -s flag so remove the special
> > handling when determining the target OS. Use arch -s to retrieve the
> > hardware architecture as uname -m will return the meta architecture
> > instead of the hardware architecture (.e.g. macppc vs powerpc).
> 
> I'm afraid I think this patch is moving in the wrong direction.
> Wherever possible we should be using compiler checks like check_define,
> not looking at the output of 'uname' and the like. The former will
> work when cross compiling, and the latter will give the wrong answers.
> In some places we have that kind of 'look at uname/etc' check but
> we should be trying to reduce and eliminate it where possible.

Ah, ok. I thought maybe it could be simplified in favor of using
uname more so. That's fine with me. I'll drop it.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.