[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child |
Date: |
Fri, 24 Aug 2012 16:44:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
>
> qmp and qdev need it.
>
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
> include/qemu/object.h | 3 +++
> qom/object.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/include/qemu/object.h b/include/qemu/object.h
> index 7cc3ebb..0142da4 100644
> --- a/include/qemu/object.h
> +++ b/include/qemu/object.h
> @@ -914,6 +914,9 @@ Object *object_resolve_path_component(Object *parent,
> gchar *part);
> void object_property_add_child(Object *obj, const char *name,
> Object *child, struct Error **errp);
>
> +void object_property_del_child(Object *obj, Object *child,
> + struct Error **errp);
> +
> /**
> * object_property_add_link:
> * @obj: the object to add a property to
> diff --git a/qom/object.c b/qom/object.c
> index be460df..6c90cfa 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -345,7 +345,7 @@ static void object_property_del_all(Object *obj)
> }
> }
>
> -static void object_property_del_child(Object *obj, Object *child, Error
> **errp)
> +void object_property_del_child(Object *obj, Object *child, Error **errp)
> {
> ObjectProperty *prop;
>
>
Not needed, see my reply to patch 9.
Paolo
- Re: [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target, (continued)
- [Qemu-devel] [PATCH 02/10] qdev: change iterator callback seq, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 04/10] qdev: introduce new interface to remove composite sub-tree, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child, Liu Ping Fan, 2012/08/24
- Re: [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_peripheral, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Liu Ping Fan, 2012/08/24