Re: [Qemu-devel] [PATCH 08/10] qdev: rename qdev_unplug to qdev_unplug_req

[Paolo Bonzini]

Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
> 
> Unplug divides into two steps: request and complete
> The name "req" show more clearly about its meaning

But not enough.  Let's make it "qdev_request_unplug", and change the
method name in the DeviceClass too.

> and as to the complete, it is qdev_delete_subtree()

Completing unplug is just qdev_free after commit da5a44e (qom:
object_delete should unparent the object first, 2012-08-22).

> Also adding ret to indicate the request can be eject or not

This is also given by the Error object.  Returning the same thing twice
is guaranteed to give bugs because the two get out of sync.

Paolo

> Signed-off-by: Liu Ping Fan <address@hidden>