Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

[Andreas Färber]

Am 24.08.2012 20:05, schrieb Aurelien Jarno:
> On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote:
>> Not opposed to changing the argument order, but given that we're inches
>> away from v1.2 (in Hard Freeze), it might be better to first get AREG0
>> as first argument working for your favorite hosts as a bugfix and then
>> do any larger optimization for v1.3.
> 
> It's what I tried to do first, but I don't think it is realistic to use
> such a code for v1.2, it is complex to support all cases, and thus
> likely full of bugs. Maybe we should simply disable ARM and MIPS support
> for this release.

Depends on what you mean with "disable"? Adding an #error would hurt our
arm build just like earlier the ppc build, and I would hope from my last
testing that the problems would only affect the AREG0 targets,
especially not ARM on ARM (or MIPS on MIPS).

Aborting at runtime, only when really unsupported, would seem better.

I had taken a look at tcg/arm/ shortly after having fixed ppc (seeing
that there was a similar TODO or FIXME) but got distracted by other
projects. And your remarks wrt stack sound a bit frightening now. ;)
@Peter, have you looked into tcg/arm/ AREG0 support?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg