Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

[Paolo Bonzini]

Il 25/08/2012 09:42, liu ping fan ha scritto:
>> >
>> > I don't see why MMIO dispatch should hold the IDEBus ref rather than the
>> > PCIIDEState.
>> >
> When transfer memory_region_init_io()  3rd para from void* opaque to
> Object* obj,  the obj : opaque is not neccessary 1:1 map. For such
> situation, in order to let MemoryRegionOps tell between them, we
> should pass PCIIDEState->bus[0], bus[1] separately.

The rule should be that the obj is the object that you want referenced,
and that should be the PCIIDEState.

But this is anyway moot because it only applies to objects that are
converted to use unlocked dispatch.  This likely will not be the case
for IDE.

Paolo

>> > In the case of the PIIX, the BARs are set up by the PCIIDEState in
>> > bmdma_setup_bar (called by bmdma_setup_bar).
>> >
> Supposing we have convert  PCIIDEState->bmdma[0]/[1] to Object. And in
> mmio-dispatch, object_ref will impose on bmdma[0/[1], but this can not
> prevent  PCIIDEState->refcnt=0, and then the whole object disappear!