Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

[Michael S. Tsirkin]

On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote:
> On 2012-08-27 14:42, Peter Maydell wrote:
> > On 27 August 2012 13:20, Michael S. Tsirkin <address@hidden> wrote:
> >> Update linux-headers to version present in Linux 3.6-rc3.
> >> Header asm-x96_64/kvm_para.h update is needed for the new PV EOI
> >> feature.
> >>
> >> Signed-off-by: Michael S. Tsirkin <address@hidden>
> >> ---
> >>  linux-headers/asm-s390/kvm.h      | 2 +-
> >>  linux-headers/asm-s390/kvm_para.h | 2 +-
> >>  linux-headers/asm-x86/kvm.h       | 1 +
> >>  linux-headers/asm-x86/kvm_para.h  | 7 +++++++
> >>  linux-headers/linux/kvm.h         | 3 +++
> >>  5 files changed, 13 insertions(+), 2 deletions(-)
> > 
> > The latest version of update-linux-headers.sh should have caused
> > this update to include asm-generic/kvm_para.h, I think. Did the
> > script not pull that header in, or were you maybe using an old
> > version of the script or forgot to git add the new file?
> 
> To be fair, that is hard to guess. We should add some magic to the
> update script to detect new files and maybe suggest them for addition.
> 
> Jan

But why did you add a header to qemu without adding it
to git? That's a cleaner solution and needs no magic scripting.

> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux