Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

[Peter Maydell]

On 28 August 2012 17:01, Michael S. Tsirkin <address@hidden> wrote:
> We copied HACKING from libvirt but it has some bogus stuff:
> neither underscore capital, double underscore, or underscore 't' suffixes
> are reserved in Posix/C: this appears to be based on misreading of the
> C standard. Using sane prefixes is enough to avoid conflicts.

> -2.4. Reserved namespaces in C and POSIX
> -Underscore capital, double underscore, and underscore 't' suffixes should be
> -avoided.

I think this is just a missing "prefixes". C99 7.1.3
reserves underscore capital and double underscore prefixes.
POSIX reserves _t if any POSIX header is defined (POSIX.1-2008 section
2.2.2, http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html)

I would suggest that the section is reworded to:

# Underscore capital and double underscore prefixes are reserved
# by the C standard. Underscore 't' suffixes are reserved by POSIX.
# They should be avoided in QEMU code.

-- PMM