[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older c
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types |
|
Date: |
Tue, 28 Aug 2012 20:38:59 +0300 |
On Tue, Aug 28, 2012 at 05:28:22PM +0000, Blue Swirl wrote:
> On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin <address@hidden> wrote:
> > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote:
> >> > +static bool _kvm_pv_eoi_disabled;
> >>
> >> NACK. I find your lack of compliance disturbing.
> >
> > Compliance with what? Could you please add some
> > motivation for the NACK?
>
> You did not respect my review comments.
I merely asking for motivation for the comments.
Anyway, malc explained it to me so I got it now.
Thanks for the review will post soon.
> >
> > --
> > MST
[Qemu-devel] [PATCHv3 4/4] kvm: get/set PV EOI MSR, Michael S. Tsirkin, 2012/08/28