Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

[Jan Kiszka]

On 2012-08-28 23:26, Peter Maydell wrote:
> On 27 August 2012 13:15, Jan Kiszka <address@hidden> wrote:
>> On 2012-08-27 14:07, Andreas Färber wrote:
>>> Am I correct to understand we compile this only for i386 / x86_64?
>>
>> This is correct.
> 
> Did we ever make a decision about whether architecture specific
> KVM devices should all live in hw/kvm/ or in some directory
> with the arch name in it? I guess they're all in hw/kvm/ at
> the moment so they should stay there unless there's a pressing
> reason to move them around...

Yep, that would be the plan. As long as there are x86 platform devices
under hw/kvm, I see no point putting this one elsewhere. It's trivially
moved when time has come.

> 
> Since this is arch-specific we should probably give the
> resulting device a more specific name than "pci-assign",
> which implies that it is (a) ok for any PCI system and
> (b) not something that will be obsolete in the foreseen
> future.

The name has to be like this for libvirt compatibility. I can provide it
as alias, though, calling the device "kvm-pci-assign" by default. Better?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux