[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-1.2 11/11] uas: move transfer kickoff
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH for-1.2 11/11] uas: move transfer kickoff |
Date: |
Fri, 31 Aug 2012 16:19:22 +0200 |
Kick next scsi transfer from request release callback instead of command
completion callback, otherwise we might get stuck in case scsi_req_unref()
doesn't release the request instantly due to someone else holding a
reference too.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-uas.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index b13eeba..5a0057a 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -424,6 +424,7 @@ static void usb_uas_scsi_free_request(SCSIBus *bus, void
*priv)
}
QTAILQ_REMOVE(&uas->requests, req, next);
g_free(req);
+ usb_uas_start_next_transfer(uas);
}
static UASRequest *usb_uas_find_request(UASDevice *uas, uint16_t tag)
@@ -456,7 +457,6 @@ static void usb_uas_scsi_command_complete(SCSIRequest *r,
uint32_t status, size_t resid)
{
UASRequest *req = r->hba_private;
- UASDevice *uas = req->uas;
trace_usb_uas_scsi_complete(req->uas->dev.addr, req->tag, status, resid);
req->complete = true;
@@ -465,7 +465,6 @@ static void usb_uas_scsi_command_complete(SCSIRequest *r,
}
usb_uas_queue_sense(req, status);
scsi_req_unref(req->req);
- usb_uas_start_next_transfer(uas);
}
static void usb_uas_scsi_request_cancelled(SCSIRequest *r)
--
1.7.1
- [Qemu-devel] [PULL for-1.2 00/11] usb patch queue, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 10/11] ehci: Fix interrupt endpoints no longer working, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 03/11] usb: unique packet ids, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 07/11] ehci: simplify ehci_state_executing, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 04/11] ehci: Fix NULL ptr deref when unplugging an USB dev with an iso stream active, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 05/11] ehci: Schedule async-bh when IAAD bit gets set, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 09/11] ehci: handle TD deactivation of inflight packets, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 11/11] uas: move transfer kickoff,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH for-1.2 06/11] ehci: Remove unnecessary ehci_flush_qh call, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 08/11] ehci: add ehci_cancel_queue(), Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 02/11] usb: Halt ep queue en cancel pending packets on a packet error, Gerd Hoffmann, 2012/08/31
- [Qemu-devel] [PATCH for-1.2 01/11] fix info qtree indention, Gerd Hoffmann, 2012/08/31