qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] block/curl: Fix wrong free statement


From: Stefan Weil
Subject: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement
Date: Sat, 1 Sep 2012 11:06:45 +0200

Report from smatch:
block/curl.c:546 curl_close(21) info: redundant null check on s->url calling 
free()

The check was redundant, and free was also wrong because the memory
was allocated using g_strdup.

Signed-off-by: Stefan Weil <address@hidden>
---
 block/curl.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/curl.c b/block/curl.c
index e7c3634..c1074cd 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -542,8 +542,7 @@ static void curl_close(BlockDriverState *bs)
     }
     if (s->multi)
         curl_multi_cleanup(s->multi);
-    if (s->url)
-        free(s->url);
+    g_free(s->url);
 }
 
 static int64_t curl_getlength(BlockDriverState *bs)
-- 
1.7.10




reply via email to

[Prev in Thread] Current Thread [Next in Thread]