[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-ga: Remove unreachable code after g_error
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-ga: Remove unreachable code after g_error |
Date: |
Mon, 3 Sep 2012 13:49:20 -0300 |
On Sat, 1 Sep 2012 09:34:15 +0200
Stefan Weil <address@hidden> wrote:
> Report from smatch:
> qemu-ga.c:117 register_signal_handlers(11) info: ignoring unreachable code.
> qemu-ga.c:122 register_signal_handlers(16) info: ignoring unreachable code.
>
> g_error calls abort which terminates the program.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> qemu-ga.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index 7623079..b747470 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -114,12 +114,10 @@ static gboolean register_signal_handlers(void)
> ret = sigaction(SIGINT, &sigact, NULL);
> if (ret == -1) {
> g_error("error configuring signal handler: %s", strerror(errno));
> - return false;
Good catch, but we should really drop g_error() usage as qemu-ga will not
fail gracefully otherwise (will leak the pidfile, for example). We either
just drop g_error() or replace it by fprintf().
> }
> ret = sigaction(SIGTERM, &sigact, NULL);
> if (ret == -1) {
> g_error("error configuring signal handler: %s", strerror(errno));
> - return false;
> }
>
> return true;