|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions |
Date: | Tue, 04 Sep 2012 15:15:28 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 |
δΊ 2012-9-3 23:18, Paolo Bonzini ει:
Il 03/09/2012 16:28, Eric Blake ha scritto:+/* this file contains helper function used internally. */ +#define SECTOR_SIZE (512)Hard-coding this feels wrong, in this day and age of disks with 4096 sectors. Why isn't this a per-image property?In this day and age of disks with 4096 sectors, Linux does not provide a way to query the required alignment for O_DIRECT... Paolo
in block.h: #define BDRV_SECTOR_BITS 9 #define BDRV_SECTOR_SIZE (1ULL << BDRV_SECTOR_BITS) #define BDRV_SECTOR_MASK ~(BDRV_SECTOR_SIZE - 1) it seems block size is always 512 in qemu block layer, so I can ignore the 4096 case, do you think so? -- Best Regards Wenchao Xia
[Prev in Thread] | Current Thread | [Next in Thread] |