[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capabilit
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers |
Date: |
Tue, 04 Sep 2012 15:30:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
On 08/30/12 14:49, Alejandro Martinez Ruiz wrote:
> Some xHC drivers (most notably on Windows and BSD systems) read
> the first capability registers using 1 and 2 bytes accesses, since
> this is how they are defined in section 5.3 of the xHCI specs.
>
> Enabling these kind of read accesses allows Windows and FreeBSD
> guests to properly recognize the host controller.
>
> As this is an exception to the general 4-byte aligned accesses rule,
> we special-case the code path for capability reading and implement
> checks to guard against wrong size/alignment combinations.
No need to do that by hand, the memory api can handle it. Can you check
whenever usb-next
(http://www.kraxel.org/cgit/qemu/log/?h=rebase/usb-next) works for you?
thanks,
Gerd
- Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers,
Gerd Hoffmann <=