Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

[Eric Blake]

On 09/05/2012 01:53 PM, Blue Swirl wrote:
> On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori <address@hidden> wrote:
>> This is minimalistic and just contains the basic widget infrastructure.  The 
>> GUI
>> consists of a menu and a GtkNotebook.  To start with, the notebook has its 
>> tabs
>> hidden which provides a UI that looks very similar to SDL with the exception 
>> of
>> the menu bar.
>>

>> +#ifdef DEBUG_GTK
>> +#define dprintf(fmt, ...) printf(fmt, ## __VA_ARGS__)
> 
> dprintf is actually defined by stdio.h. Either rename or #undef first.

Worse than that, dprintf() is mandated by POSIX 2008, and you are using
a reserved name with different meaning, which can give undefined
behavior.  Your best bet is to use a name other than dprintf.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature