[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 19/19] tcx: tcx_screen_dump(): add error handling
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 19/19] tcx: tcx_screen_dump(): add error handling |
Date: |
Wed, 5 Sep 2012 15:58:46 -0300 |
Signed-off-by: Luiz Capitulino <address@hidden>
---
hw/tcx.c | 35 +++++++++++++++++++++++++++++------
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/hw/tcx.c b/hw/tcx.c
index 428649e..93994d6 100644
--- a/hw/tcx.c
+++ b/hw/tcx.c
@@ -582,26 +582,49 @@ static void tcx_screen_dump(void *opaque, const char
*filename, bool cswitch,
TCXState *s = opaque;
FILE *f;
uint8_t *d, *d1, v;
- int y, x;
+ int ret, y, x;
f = fopen(filename, "wb");
- if (!f)
+ if (!f) {
+ error_setg(errp, "failed to open file '%s': %s", filename,
+ strerror(errno));
return;
- fprintf(f, "P6\n%d %d\n%d\n", s->width, s->height, 255);
+ }
+ ret = fprintf(f, "P6\n%d %d\n%d\n", s->width, s->height, 255);
+ if (ret < 0) {
+ goto write_err;
+ }
d1 = s->vram;
for(y = 0; y < s->height; y++) {
d = d1;
for(x = 0; x < s->width; x++) {
v = *d;
- fputc(s->r[v], f);
- fputc(s->g[v], f);
- fputc(s->b[v], f);
+ ret = fputc(s->r[v], f);
+ if (ret == EOF) {
+ goto write_err;
+ }
+ ret = fputc(s->g[v], f);
+ if (ret == EOF) {
+ goto write_err;
+ }
+ ret = fputc(s->b[v], f);
+ if (ret == EOF) {
+ goto write_err;
+ }
d++;
}
d1 += MAXX;
}
+
+out:
fclose(f);
return;
+
+write_err:
+ error_setg(errp, "failed to write to file '%s': %s", filename,
+ strerror(errno));
+ unlink(filename);
+ goto out;
}
static void tcx24_screen_dump(void *opaque, const char *filename, bool cswitch,
--
1.7.11.2.249.g31c7954.dirty
- [Qemu-devel] [PATCH 06/19] qapi: add the QKeyCode enum, (continued)
- [Qemu-devel] [PATCH 06/19] qapi: add the QKeyCode enum, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 07/19] monitor: move key_defs[] table and introduce two help functions, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfault, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 08/19] qapi: convert sendkey, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 09/19] qapi: Fix potential NULL pointer segfault, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 11/19] error: add error_setg(), Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 14/19] vga: ppm_save(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 13/19] qapi: convert screendump, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 15/19] omap_lcdc: rename ppm_save() to omap_ppm_save(), Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 12/19] console: vga_hw_screen_dump_ptr: take Error argument, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 19/19] tcx: tcx_screen_dump(): add error handling,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 17/19] g364fb: g364fb_screen_dump(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 16/19] omap_lcdc: omap_ppm_save(): add error handling, Luiz Capitulino, 2012/09/05
- [Qemu-devel] [PATCH 18/19] tcx: tcx24_screen_dump(): add error handling, Luiz Capitulino, 2012/09/05
- Re: [Qemu-devel] [PULL 00/19]: QMP queue, Aurelien Jarno, 2012/09/10