[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2) |
Date: |
Wed, 05 Sep 2012 15:40:31 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Jan Kiszka <address@hidden> writes:
> On 2012-09-05 21:18, Anthony Liguori wrote:
>> There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt
>> triggering grab, we now use Ctrl-Alt-g to trigger grab.
>>
>> GTK will not accept Ctrl+Alt as an accelerator since it just consists of
>> modifiers. Having grab as a proper accelerator is important as it allows a
>> user
>> to override the accelerator for accessibility purposes.
>>
>> We also are not automatically grabbing on left-click. Besides the inability
>> to
>> tie mouse clicks to an accelerator, I think this behavior is hard to discover
>> and since it only happens depending on the guest state, it can lead to
>> confusing
>> behavior.
>>
>> This can be changed in the future if there's a strong resistence to dropping
>> left-click-to-grab, but I think we're better off dropping it.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>> v1 -> v2
>> - add a menu option for grab on hover (Jan)
>
> Thanks. Are options like this persistent across VM starts?
No. I don't want to include that in this series as it opens up a whole
debate about GConf vs. configuration files...
Regards,
Anthony Liguori
>
> Jan
- Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), (continued)
Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2), Jan Kiszka, 2012/09/05
[Qemu-devel] [PATCH 3/7] gtk: add virtual console support (v2), Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 6/7] gtk: add translation support, Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2), Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 7/7] gtk: make default UI (v3), Anthony Liguori, 2012/09/05
[Qemu-devel] [PATCH 1/7] console: allow VCs to be overridden by UI, Anthony Liguori, 2012/09/05