[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline par
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline params |
Date: |
Thu, 6 Sep 2012 09:21:27 +0200 |
From: Christophe Fergeau <address@hidden>
When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name' helper makes sure we
error out in this case. Looking at git history, the use of
'name2enum' instead of 'parse_name' seems to have been an oversight,
so let's change to that now.
Fixes rhbz#831708
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/spice-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 4fc48f8..bb4f585 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -344,7 +344,8 @@ static const char *stream_video_names[] = {
[ SPICE_STREAM_VIDEO_FILTER ] = "filter",
};
#define parse_stream_video(_name) \
- name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names))
+ parse_name(_name, "stream video control", \
+ stream_video_names, ARRAY_SIZE(stream_video_names))
static const char *compression_names[] = {
[ SPICE_IMAGE_COMPRESS_OFF ] = "off",
--
1.7.1
- [Qemu-devel] [PULL 00/14] spice patch queue, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 14/14] Remove #ifdef QXL_COMMAND_FLAG_COMPAT_16BPP, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 03/14] spice: notify on vm state change only via spice_server_vm_start/stop, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 06/14] spice: adding seamless-migration option to the command line, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 02/14] spice: notify spice server on vm start/stop, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 05/14] spice: add 'migrated' flag to spice info, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline params,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 12/14] spice: make number of surfaces runtime-configurable., Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 11/14] configure: print spice-protocol and spice-server versions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 07/14] spice: increase the verbosity of spice section in "qemu --help", Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 13/14] qxl: Add set_client_capabilities() interface to QXLInterface, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 09/14] qxl: disallow unknown revisions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 04/14] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid parameters, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PULL 00/14] spice patch queue, Aurelien Jarno, 2012/09/10