Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

[Peter Maydell]

On 6 September 2012 08:42, Gerd Hoffmann <address@hidden> wrote:
> @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev)
>          isa->isairq = isa_serial_irq[isa->index];
>      index++;
>
> +    if (isa->iobase == 0x3f8) {
> +        s->reason = QEMU_WAKEUP_REASON_GPE_a;
> +        s->wakeup = 1;
> +    } else {
> +        s->reason = QEMU_WAKEUP_REASON_OTHER;
> +    }
> +

It seems a bit odd that this is done in the ISA serial model
itself and not by the next level up wiring up some output
of the ISA serial device to some appropriate input...

-- PMM