qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capabilit


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers
Date: Thu, 06 Sep 2012 12:15:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7

  Hi,

> usb-next will fail to compile using -Werror with:
> hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’:
> hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used
> [-Werror=unused-but-set-variable]

Fixed.

Which gcc is this?  Must be pretty cutting edge, even on Fedora 17 (gcc
4.7.0) I don't see that one ...

> It will also crash at runtime at
> host-linux.c:usb_handle_control_packet(), since a NULL value is passed
> from xhci_address_slot() for the USBPacket *p argument, and an assert
> is testing for p->result == 0.

Fixed & pushed to usb-next.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]