Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

[Alejandro Martinez]

Hi Gerd,

On Thu, Sep 6, 2012 at 12:15 PM, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
>> usb-next will fail to compile using -Werror with:
>> hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’:
>> hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used
>> [-Werror=unused-but-set-variable]
>
> Fixed.
>
> Which gcc is this?  Must be pretty cutting edge, even on Fedora 17 (gcc
> 4.7.0) I don't see that one ...

Actually it is from OpenSuSE's 12.1 rpm, at version 4.6.2.

>> It will also crash at runtime at
>> host-linux.c:usb_handle_control_packet(), since a NULL value is passed
>> from xhci_address_slot() for the USBPacket *p argument, and an assert
>> is testing for p->result == 0.
>
> Fixed & pushed to usb-next.

Thanks, will try it out.

Thanks,
  Alex