Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

[Edgar E. Iglesias]

 > > >                  case 6:
> > > 
> > > Similarly to what I reported for the microblaze and sh4 target, I think
> > > we should not start using cpu_single_env (a global variable) to replace
> > > env (a global variable stored in a register). 
> > > 
> > > It is possible to pass env through the subroutine, though it is more 
> > > complicated there than for other targets. I have therefore done the work
> > > and I have attached the two resulting patches to this mail.
> > 
> > Hi Aurelien!
> > 
> > I agree with your comment and change. The indentation looks a bit odd
> > here though. The CRISv32 port used tabs when written but some patches
> > have made it in that used space, so it's become a bit of a mess. Maybe
> > it's time to convert it to the QEMU codingstyle?
> 
> Yes, I tried to make script/checkpatch.pl happy as I know Blue Swirl
> really care about that.
> 
> > From my point of view, I think we should either keep the tabs or change
> > the whole file for 4 space indent.
> > 
> > I've got nothing against applying your patch as is and then on top of that
> > the mechanical untabification, to avoid extra work on your side.
> > 
> 
> As you prefer, I can also provide the same patches with tabs instead.

OK, please keep your patch and when it's applied I'll put an untabification
on top.

Cheers,
Edgar