Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

[Blue Swirl]

On Thu, Sep 6, 2012 at 7:00 PM, Peter Maydell <address@hidden> wrote:
> On 4 September 2012 21:48, Peter Maydell <address@hidden> wrote:
>> On 4 September 2012 21:37, Blue Swirl <address@hidden> wrote:
>>> Add an explicit CPUState parameter instead of relying on AREG0.
>>>
>>> For easier review, convert only op helpers which don't return any value.
>>>
>>> Signed-off-by: Blue Swirl <address@hidden>
>>
>> Reviewed-by: Peter Maydell <address@hidden>
>>
>> Thanks for splitting these up, it helped a lot.
>
> Forgot to ask, are you planning to apply these directly?
> I'm happy to take them via the target-arm tree but I imagine
> there'll be merge conflicts on that line in configure if we
> do that for every target...

That was my original plan (which I didn't spell out, mea culpa), but
since Alex already took the s390x patches via his tree, we'll see what
will happen with the commit order.

>
> thanks
> -- PMM