Re: [Qemu-devel] [PATCH 00/12] Rework PCI video card initialization

[Alexander Graf]

On 08.09.2012, at 13:26, Aurelien Jarno <address@hidden> wrote:

> This patch series is technically a new version of the "add a video
> card only when requested" series I sent yesterday. It uses a different
> approach though.
> 
> It creates a new pci_vga_init() function that takes care of initializing
> the requested PCI video card. This way there is no need to duplicate
> code in the various machines QEMU supports, and has the advantage that
> the newly added PCI video cards are available to all machines without
> having to touch machine specific code.
> 
> Cc: Alexander Graf <address@hidden>
> Cc: Andreas Färber <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Cc: Blue Swirl <address@hidden>
> Cc: David Gibson <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Richard Henderson <address@hidden>

Apart from my comment and the bits already mentioned, the series looks very 
good. It's certainly a trenendous cleanup + simplification of the vga code.

Alex

> 
> Aurelien Jarno (12):
>  vga: rename pci_vga_init() into pci_std_vga_init()
>  vl.c: check for qxl availability
>  pci: add a pci_vga_init() function
>  mips/malta: use the new pci_vga_init() function
>  alpha: use the new pci_vga_init() function
>  ppc/newworld: use the new pci_vga_init() function
>  ppc/oldworld: use the new pci_vga_init() function
>  ppc/prep: use the new pci_vga_init() function
>  ppc/pSeries: use the new pci_vga_init() function
>  sun/sun4u: use the new pci_vga_init() function
>  pc: use the new pci_vga_init() function
>  vga: cleanup after pci_vga_init() conversion
> 
> hw/alpha_dp264.c  |    2 +-
> hw/alpha_pci.c    |   24 ------------------------
> hw/alpha_sys.h    |    2 --
> hw/cirrus_vga.c   |    6 ------
> hw/mips_malta.c   |   10 +---------
> hw/pc.c           |   41 +++++++++++++++--------------------------
> hw/pci.c          |   18 ++++++++++++++++++
> hw/pci.h          |    3 +++
> hw/ppc_newworld.c |    1 -
> hw/ppc_oldworld.c |    1 -
> hw/ppc_prep.c     |    1 -
> hw/spapr.c        |    7 ++-----
> hw/sun4u.c        |    1 -
> hw/vga-pci.c      |   10 ++--------
> hw/vga-pci.h      |   12 ------------
> hw/vmware_vga.c   |    1 -
> hw/vmware_vga.h   |   15 ---------------
> sysemu.h          |    4 ----
> vl.c              |   12 +++++++++++-
> 19 files changed, 53 insertions(+), 118 deletions(-)
> delete mode 100644 hw/vga-pci.h
> delete mode 100644 hw/vmware_vga.h
> 
> -- 
> 1.7.10.4
> 
>