Re: [Qemu-devel] [PATCH v2 02/10] softfloat: add NO_SIGNALING_NANS

[Peter Maydell]

On 9 September 2012 17:04, Max Filippov <address@hidden> wrote:
> Architectures that don't have signaling NaNs can define
> NO_SIGNALING_NANS, it will make float*_is_quiet_nan return 1 for any NaN
> and float*_is_signaling_nan always return 0.
>
> Signed-off-by: Max Filippov <address@hidden>
> ---
>  fpu/softfloat-specialize.h |   64 
> ++++++++++++++++++++++++++++++++++++++++++++
>  fpu/softfloat.h            |    5 +++
>  2 files changed, 69 insertions(+), 0 deletions(-)
>
> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
> index 4902450..2b203b9 100644
> --- a/fpu/softfloat-specialize.h
> +++ b/fpu/softfloat-specialize.h
> @@ -41,6 +41,10 @@ these four paragraphs for those parts of this code that 
> are retained.
>  #define SNAN_BIT_IS_ONE                0
>  #endif
>
> +#if defined(TARGET_XTENSA)
> +#define NO_SIGNALING_NANS 1
> +#endif

This could use a comment, I think.
/* Define for architectures which deviate from IEEE in not supporting
 * signaling NaNs (so all NaNs are treated as quiet).
 */

-- PMM