Re: [Qemu-devel] [PATCH] tcg/i386: allow constants in load/store ops

[Aurelien Jarno]

On Mon, Sep 10, 2012 at 06:40:09AM -0700, Richard Henderson wrote:
> On Mon, 2012-09-10 at 13:56 +0200, Aurelien Jarno wrote:
> > On x86, it is possible to move a constant value to memory. Add code to
> > handle a constant argument to load/store ops.
> > 
> > Signed-off-by: Aurelien Jarno <address@hidden> 
> 
> While useful, you'll find that most constants that want storing to
> memory are not generated with store opcodes, but directly via
> tcg_out_st.  As happens for all register spilling, and helper calls.

It actually depends on the target. Some of them are not using that at
all, some of them are using that a lot.

Ideally we would need to also do that directly from TCG when storing
back registers to their canonical location, but we have to find a nice
clean to do it.

> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
> r~
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net