[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info |
Date: |
Tue, 11 Sep 2012 09:12:36 -0400 (EDT) |
----- Messaggio originale -----
> Da: "Kevin Wolf" <address@hidden>
> A: "Paolo Bonzini" <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden, address@hidden
> Inviato: Martedì, 11 settembre 2012 15:07:05
> Oggetto: Re: [PATCH 19/47] block: add bdrv_query_info
>
> Am 24.07.2012 13:03, schrieb Paolo Bonzini:
> > Extract it out of the implementation of "info block".
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> > block.c | 104
> > +++++++++++++++++++++++++++++++--------------------------------
> > block.h | 1 +
> > 2 files changed, 53 insertions(+), 52 deletions(-)
>
> The refactoring looks correct, but why do you put the function between
> qmp_query_blockstat and qmp_query_blockstats? If you put it next to
> qmp_query_block, both functions pairs stay closer together.
Ok, will do.
Paolo